[ConstraintSystem] Fix a misleading argument mismatch error when using wrapped parameters. #39146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling a function with a wrapped parameter, the solver will produce a misleading error message if the argument type isn't convertible to the parameter type:
This happens because when type checking the function call, the solver will generate constraints for the property wrapper attribute chain, which will equate each wrapped-value type of a wrapper attribute with the next property wrapper attribute type (or the property type itself, if it's the innermost wrapper attribute).
For regular function parameters, these constraints were already generated and solved for when type checking the parameter declaration anyway, and they don't need to be repeated for function calls. This only needs to be done for closure parameters, so the fix is to only call
generateWrappedPropertyTypeConstraints
when resolving closures.Resolves: SR-15030