Skip to content

[NFC] Remove old comment related to port diagnostics to new framework #39074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

LucianoPAlmeida
Copy link
Contributor

Found while investigating another issue, I think this comment doesn't apply anymore

@LucianoPAlmeida LucianoPAlmeida requested a review from xedin August 27, 2021 12:23
@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please smoke test

@LucianoPAlmeida
Copy link
Contributor Author

Friendly ping @xedin ;)

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I completely missed this one! Looks good!

@xedin xedin merged commit e4e2cdd into swiftlang:main Sep 4, 2021
@LucianoPAlmeida LucianoPAlmeida deleted the minor-fixes branch September 4, 2021 01:06
@LucianoPAlmeida
Copy link
Contributor Author

Sorry, I completely missed this one! Looks good!

No worries, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants