[Distributed] Generate SIL for DistributedActor.resolve #38938

drexin · 2021-08-18T20:56:55Z

rdar://78484431

drexin · 2021-08-18T20:57:07Z

drexin · 2021-08-18T21:11:49Z

ktoso · 2021-08-18T21:16:11Z

lib/SILGen/SILGenDistributed.cpp

+  auto switchBB = createBasicBlock();
+  auto errorBB = createBasicBlock();
+
+  SILFunctionConventions fnConv = F.getConventions(); // TODO: no idea?


Suggested change

SILFunctionConventions fnConv = F.getConventions(); // TODO: no idea?

SILFunctionConventions fnConv = F.getConventions();

seems to be right I guess :)

ktoso · 2021-08-18T21:17:49Z

lib/SILGen/SILGenDistributed.cpp

+  // --- get the uninitialized allocation from the runtime system.
+  FullExpr scope(Cleanups, CleanupLocation(fd));
+
+  auto optionalReturnTy = SILType::getOptionalType(returnTy);


nice optionals made things a bit easier :)

ktoso

Looks good! We can remove the TODOs that this addressed I guess

ktoso · 2021-08-18T21:18:49Z

lib/SILGen/SILGenDistributed.cpp

+    auto local = resolvedBB->createPhiArgument(returnTy, OwnershipKind::Owned);
+
+    B.createBranch(loc, returnBB, {local});
+  }


oh nice, not too hard then 👍

ktoso · 2021-08-18T21:19:01Z

lib/SILGen/SILGenDistributed.cpp

-  assert(transportVarDeclRefs.size() == 1);
-  auto *transportVarDeclRef = dyn_cast<VarDecl>(transportVarDeclRefs.front());
+  auto transportVarDeclRef = lookupActorTransportProperty(ctx, cd, selfValue);
+


ktoso · 2021-08-18T21:19:44Z

lib/SILGen/SILGenFunction.cpp


  if (fd->isDistributedActorFactory()) {
    // Synthesize the factory function body
    emitDistributedActorFactory(fd);
  } else {
+    prepareEpilog(true, fd->hasThrows(), CleanupLocation(fd));
+


I see, so we emit the cleanups ourselves ok 👍

ktoso · 2021-08-18T21:19:55Z

stdlib/public/Distributed/ActorTransport.swift

@@ -48,7 +48,7 @@ public protocol ActorTransport: Sendable {
  ///
  /// Detecting liveness of such remote actors shall be offered / by transport libraries
  /// by other means, such as "watching an actor for termination" or similar.
-  func resolve<Act>(_ identity: AnyActorIdentity, as actorType: Act.Type) throws -> ActorResolved<Act> // TODO(distributed): make just optional
+  func resolve<Act>(_ identity: AnyActorIdentity, as actorType: Act.Type) throws -> Act? // TODO(distributed): make just optional


Suggested change

func resolve<Act>(_ identity: AnyActorIdentity, as actorType: Act.Type) throws -> Act? // TODO(distributed): make just optional

func resolve<Act>(_ identity: AnyActorIdentity, as actorType: Act.Type) throws -> Act?

drexin · 2021-08-18T23:35:08Z

@swift-ci smoke test

drexin · 2021-08-19T07:21:01Z

@swift-ci smoke test

…teActor

rdar://78484431

drexin · 2021-08-20T00:33:28Z

@swift-ci smoke test

ktoso · 2021-08-20T00:41:03Z

lib/IRGen/GenDistributed.cpp

@@ -41,9 +47,11 @@ llvm::Value *irgen::emitDistributedActorInitializeRemote(
  call->setCallingConv(IGF.IGM.SwiftCC);
  call->setDoesNotThrow();

-  out.add(call);
+  auto result = IGF.Builder.CreateBitCast(call, destType);


huh I see, very good to know..! Thanks a lot!

This reverts commit a4f3f2f, reversing changes made to 8cf6c2e.

…e" (#38994)" This reverts commit f6ae9f3.

…st-resolve" (swiftlang#38994)" This reverts commit f6ae9f3.

…e" (#38994)" (#39011) This reverts commit f6ae9f3.

* Revert "Revert "Merge pull request #38938 from drexin/wip-dist-resolve" (#38994)" This reverts commit f6ae9f3. * [Distributed] decode init for DistributedActor

drexin requested review from ktoso and kavon August 18, 2021 20:57

drexin closed this Aug 18, 2021

drexin force-pushed the wip-dist-resolve branch from 5b568f7 to 0daa9cc Compare August 18, 2021 20:59

drexin reopened this Aug 18, 2021

drexin force-pushed the wip-dist-resolve branch 2 times, most recently from e41627a to 20bd427 Compare August 18, 2021 21:06

ktoso added the distributed Feature → concurrency: distributed actor label Aug 18, 2021

drexin force-pushed the wip-dist-resolve branch from 20bd427 to cb0dc1d Compare August 18, 2021 21:11

ktoso reviewed Aug 18, 2021

View reviewed changes

ktoso approved these changes Aug 18, 2021

View reviewed changes

drexin force-pushed the wip-dist-resolve branch from cb0dc1d to bd62b7a Compare August 18, 2021 23:34

drexin force-pushed the wip-dist-resolve branch from bd62b7a to d69ab78 Compare August 19, 2021 07:20

drexin added 2 commits August 19, 2021 17:31

[Distributed] Fix type lowering for Builtin.initializeDistributedRemo…

810e2cf

…teActor

[Distributed] Generate SIL for DistributedActor.resolve

3161d8f

rdar://78484431

drexin force-pushed the wip-dist-resolve branch from d69ab78 to 3161d8f Compare August 20, 2021 00:32

ktoso reviewed Aug 20, 2021

View reviewed changes

drexin merged commit a4f3f2f into swiftlang:main Aug 20, 2021

drexin deleted the wip-dist-resolve branch August 20, 2021 04:46

ktoso added a commit to ktoso/swift that referenced this pull request Aug 23, 2021

Revert "Merge pull request swiftlang#38938 from drexin/wip-dist-resolve"

1950e22

This reverts commit a4f3f2f, reversing changes made to 8cf6c2e.

ktoso mentioned this pull request Aug 23, 2021

Revert "[Distributed] Generate SIL for DistributedActor.resolve" #38994

Merged

ktoso added a commit that referenced this pull request Aug 23, 2021

Revert "Merge pull request #38938 from drexin/wip-dist-resolve" (#38994)

f6ae9f3

This reverts commit a4f3f2f, reversing changes made to 8cf6c2e.

drexin added a commit that referenced this pull request Aug 23, 2021

Revert "Revert "Merge pull request #38938 from drexin/wip-dist-resolv…

d89d02d

…e" (#38994)" This reverts commit f6ae9f3.

ktoso added a commit to ktoso/swift that referenced this pull request Aug 23, 2021

Revert "Revert "Merge pull request swiftlang#38938 from drexin/wip-di…

e3e115f

…st-resolve" (swiftlang#38994)" This reverts commit f6ae9f3.

ktoso pushed a commit that referenced this pull request Aug 24, 2021

Revert "Revert "Merge pull request #38938 from drexin/wip-dist-resolv…

d43ea45

…e" (#38994)" (#39011) This reverts commit f6ae9f3.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Distributed] Generate SIL for DistributedActor.resolve #38938

[Distributed] Generate SIL for DistributedActor.resolve #38938

Uh oh!

drexin commented Aug 18, 2021

Uh oh!

drexin commented Aug 18, 2021

Uh oh!

drexin commented Aug 18, 2021

Uh oh!

ktoso Aug 18, 2021

Uh oh!

ktoso Aug 18, 2021

Uh oh!

ktoso left a comment

Uh oh!

ktoso Aug 18, 2021

Uh oh!

ktoso Aug 18, 2021

Uh oh!

ktoso Aug 18, 2021

Uh oh!

ktoso Aug 18, 2021

Uh oh!

drexin commented Aug 18, 2021

Uh oh!

drexin commented Aug 19, 2021

Uh oh!

drexin commented Aug 20, 2021

Uh oh!

ktoso Aug 20, 2021

Uh oh!

Uh oh!

	SILFunctionConventions fnConv = F.getConventions(); // TODO: no idea?
	SILFunctionConventions fnConv = F.getConventions();

	func resolve<Act>(_ identity: AnyActorIdentity, as actorType: Act.Type) throws -> Act? // TODO(distributed): make just optional
	func resolve<Act>(_ identity: AnyActorIdentity, as actorType: Act.Type) throws -> Act?

[Distributed] Generate SIL for DistributedActor.resolve #38938

[Distributed] Generate SIL for DistributedActor.resolve #38938

Uh oh!

Conversation

drexin commented Aug 18, 2021

Uh oh!

drexin commented Aug 18, 2021

Uh oh!

drexin commented Aug 18, 2021

Uh oh!

ktoso Aug 18, 2021

Choose a reason for hiding this comment

Uh oh!

ktoso Aug 18, 2021

Choose a reason for hiding this comment

Uh oh!

ktoso left a comment

Choose a reason for hiding this comment

Uh oh!

ktoso Aug 18, 2021

Choose a reason for hiding this comment

Uh oh!

ktoso Aug 18, 2021

Choose a reason for hiding this comment

Uh oh!

ktoso Aug 18, 2021

Choose a reason for hiding this comment

Uh oh!

ktoso Aug 18, 2021

Choose a reason for hiding this comment

Uh oh!

drexin commented Aug 18, 2021

Uh oh!

drexin commented Aug 19, 2021

Uh oh!

drexin commented Aug 20, 2021

Uh oh!

ktoso Aug 20, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!