[build-script-impl] Do not actually try to extract symbols when we perform a dry-run. #38919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS |
gottesmm
force-pushed
the
pr-26b1714e21e106018d965c705a0c01988543a372
branch
from
44b48dd to
da37d18
Compare
|
@swift-ci smoke test |
|
I added an option to restore the old testing behavior. But by default, we are now going to be able to run dry-run with toolchain. |
|
@swift-ci smoke test linux platform |
…rform a dry-run. Otherwise, we can't successfully dry-run a toolchain on darwin. I added an option enable-extract-symbol-dry-run-test that can be set to restore the previous behavior and updating the BuildSystem unit tests that depend on that behavior to pass that flag.
gottesmm
force-pushed
the
pr-26b1714e21e106018d965c705a0c01988543a372
branch
from
da37d18 to
8109819
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we can't successfully dry-run a toolchain on darwin.