Skip to content

[build-script] Use a builder to setup pass pipelines that are then scheduled when using --infer #38886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

The key thing here is that by using this builder, I am going to be able to split
the build-script-impl pipeline in two and put in a build-script pipeline in
between. This is needed so that on Linux, we can build the stage 2 compiler
before we build any of the build-script-impl libraries that depend on having a
swift compiler.

This should be an NFCI change. I am relying on our build system unit tests to
ensure that I am not changing any real behavior.

@gottesmm gottesmm requested a review from drexin August 16, 2021 06:49
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ee29b1e391dc732aa5499c79a0a4bc2fc1988f52

@gottesmm gottesmm force-pushed the pr-88e3658ca820cb93dc6145ed8648f17387c3c87e branch from ee29b1e to d7315a9 Compare August 16, 2021 08:31
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ee29b1e391dc732aa5499c79a0a4bc2fc1988f52

@gottesmm
Copy link
Contributor Author

Found the problem

…heduled when using --infer

The key thing here is that by using this builder, I am going to be able to split
the build-script-impl pipeline in two and put in a build-script pipeline in
between. This is needed so that on Linux, we can build the stage 2 compiler
before we build any of the build-script-impl libraries that depend on having a
swift compiler.

This should be an NFCI change. I am relying on our build system unit tests to
ensure that I am not changing any real behavior.
@gottesmm gottesmm force-pushed the pr-88e3658ca820cb93dc6145ed8648f17387c3c87e branch from d7315a9 to 6d50463 Compare August 18, 2021 02:54
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm merged commit 084f5b3 into swiftlang:main Aug 18, 2021
@gottesmm gottesmm deleted the pr-88e3658ca820cb93dc6145ed8648f17387c3c87e branch August 18, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants