Skip to content

Change the feature name for BuiltinTaskGroup. #38048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Jun 23, 2021

Explanation: Change a feature name so that _Concurrency.swiftmodule/*-*-.swiftinterface files from newer compilers can be parsed with older compilers and vice-versa.
Scope: Only affects inalienable code in the _Concurrency module.
Radar/SR Issue: rdar://79561865
Risk: Low.
Testing: PR testing and CI on main.
Original PR: #38047

The `createTaskGroup` builtin has changed its signature and now requires
a type metadata argument. Change the feature accordingly so that
compilers with the new and old versions have disjoint feature sets.

Fixes rdar://79561865.
@DougGregor DougGregor requested a review from a team as a code owner June 23, 2021 05:15
@DougGregor
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 5e7170b

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 5e7170b

@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please nominate

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please nominate

@tkremenek tkremenek merged commit af463f9 into swiftlang:release/5.5 Jun 24, 2021
@DougGregor DougGregor deleted the builtin-task-group-with-argument-feature-5.5 branch June 24, 2021 05:18
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants