Skip to content

[CSBindings] Avoid to infer transitive defaults for DefaultClosureType #36043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LucianoPAlmeida
Copy link
Contributor

Just a part of #35503 which was reverted due to source compatibility impact.

@xedin
Copy link
Contributor

xedin commented Feb 19, 2021

@LucianoPAlmeida This is very much FC :)

@LucianoPAlmeida LucianoPAlmeida force-pushed the nfc-transitive-closure-defaults branch from 6259225 to 76564ea Compare February 19, 2021 00:40
@LucianoPAlmeida LucianoPAlmeida changed the title [NFC] Avoid to infer transitive defaults for DefaultClosureType [CSBindings] Avoid to infer transitive defaults for DefaultClosureType Feb 19, 2021
@xedin
Copy link
Contributor

xedin commented Feb 19, 2021

@swift-ci please smoke test

@xedin
Copy link
Contributor

xedin commented Feb 19, 2021

@swift-ci please test source compatibility

@LucianoPAlmeida
Copy link
Contributor Author

@LucianoPAlmeida This is very much FC :)

Oops, you right =]

@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci please test source compatibility Release

@LucianoPAlmeida
Copy link
Contributor Author

Seems like source compatibility failures on release are unrelated,
One project is failing on EscapeAnalysis::mayReleaseContent that probably will be fixed by #36046
And the other is failing on a Driver issue... should we wait until source compatibility is fixed?

@xedin
Copy link
Contributor

xedin commented Feb 19, 2021

Yeah, it's failing on main as well. Let's land this.

@xedin xedin merged commit d394d7b into swiftlang:main Feb 20, 2021
@LucianoPAlmeida LucianoPAlmeida deleted the nfc-transitive-closure-defaults branch February 20, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants