Skip to content

[update-checkout] Add swift-crypto to the list of repos #35507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

yim-lee
Copy link
Contributor

@yim-lee yim-lee commented Jan 20, 2021

This is for swiftlang/swift-package-manager#3202, which adds swift-crypto as a new dependency to SwiftPM to support the upcoming package collection feature.

@yim-lee
Copy link
Contributor Author

yim-lee commented Jan 20, 2021

@neonichu @shahmishal @tomerd

@yim-lee
Copy link
Contributor Author

yim-lee commented Jan 20, 2021

@swift-ci test

@neonichu
Copy link
Contributor

We should also add a version to check out, I think otherwise we'll check out main. Similar to https://github.com/apple/swift/blob/main/utils/update_checkout/update-checkout-config.json#L66

@yim-lee
Copy link
Contributor Author

yim-lee commented Jan 20, 2021

Thanks @neonichu. I suppose we will need a swift-crypto version with CMake first...on it.

@yim-lee
Copy link
Contributor Author

yim-lee commented Jan 24, 2021

Use main branch for now so we can test changes in SwiftPM. We will pin to version later.

@swift-ci test

@neonichu neonichu requested a review from shahmishal January 27, 2021 01:50
This is for swiftlang/swift-package-manager#3202, which adds swift-crypto as a new dependency to SwiftPM to support the upcoming package collection feature.
Use `main` branch for now so we can test changes in SwiftPM. We will pin to version later.
@yim-lee
Copy link
Contributor Author

yim-lee commented Feb 2, 2021

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 2, 2021

Build failed
Swift Test Linux Platform
Git Sha - 2766cad

@shahmishal
Copy link
Member

01:50:29.227 ********************
01:50:29.227 Failed Tests (1):
01:50:29.227   lldb-api :: lang/swift/completion/TestSwiftREPLCompletion.py

cc: @JDevlieghere

@shahmishal
Copy link
Member

@swift-ci test linux

@yim-lee
Copy link
Contributor Author

yim-lee commented Feb 3, 2021

@shahmishal Can you please merge this? I don't have the permissions to do so. Thanks.

@shahmishal shahmishal merged commit 0b63100 into swiftlang:main Feb 3, 2021
@yim-lee yim-lee deleted the update-crypto branch February 16, 2021 20:15
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants