Skip to content

[Driver] -c with LTO should still emit bitcode #35026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2021
Merged

[Driver] -c with LTO should still emit bitcode #35026

merged 1 commit into from
Aug 20, 2021

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek kubamracek requested a review from compnerd December 9, 2020 21:46
@kubamracek
Copy link
Contributor Author

@swift-ci please test

compnerd
compnerd approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we should use a mixture of different triples (Linux, Android, Windows, macOS, iOS) just to get some test coverage even though the code is target agnostic.

@CodaFi
Copy link
Contributor

CodaFi commented Dec 11, 2020

@davidungar @artemcm Does this need to be fixed in the new driver?

artemcm added a commit to artemcm/swift-driver that referenced this pull request Dec 11, 2020
@artemcm
-c with LTO should still emit bitcode
0ed837c 
Straight-forward adaptation of:
swiftlang/swift#35026
@artemcm artemcm mentioned this pull request Dec 11, 2020
Merged
@artemcm
Copy link
Contributor

artemcm commented Dec 11, 2020

@davidungar @artemcm Does this need to be fixed in the new driver?

Thanks for catching this. Yeah, I think it does.
swiftlang/swift-driver#410 should do the job.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b09d20cb82e5e294f875792bde51d1a1ab6c1de7

@kubamracek kubamracek force-pushed the lto-output-mode-clash branch from b09d20c to ea31c04 Compare August 19, 2021 17:06
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ea31c04

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek merged commit 8cf6c2e into swiftlang:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kubamracek @CodaFi @artemcm @swift-ci @compnerd