Skip to content

[SIL] Don't verify functions that were skipped #34948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Dec 3, 2020

Don't verify the SIL of skipped functions. This was reporting false-positives in NonInlinableWithoutTypes mode.

Fix issue introduced by #34612.

@xymus
Copy link
Contributor Author

xymus commented Dec 3, 2020

@swift-ci Please smoke test

@xymus xymus force-pushed the skip-sil-verify-skipped-functions branch from 4d906eb to a218281 Compare December 4, 2020 01:50
@xymus
Copy link
Contributor Author

xymus commented Dec 4, 2020

@swift-ci Please smoke test

@xymus
Copy link
Contributor Author

xymus commented Dec 4, 2020

@swift-ci Please smoke test Windows

@xymus xymus merged commit b935c4a into swiftlang:main Dec 4, 2020
@xymus xymus deleted the skip-sil-verify-skipped-functions branch December 4, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant