Fetch associated types abstractly when fetching an associated conformance #34213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance. By default, emitTypeMetadataRef does a blocking request for complete metadata, which is the right thing to do for most purposes in IRGen. Unfortunately, it's actively dangerous in code that can be called during metadata completion, like an associated conformance accessor, because it can cause artificial dependency cycles that the runtime isn't equipped to detect, much less solve. This is a partial fix for rdar://69901318, which also exposes a bad metadata access path that seems to be causing an artificial problem.
|
@swift-ci Please test. |
rjmccall
added a commit
to rjmccall/swift
that referenced
this pull request
Oct 8, 2020
Still not sure how the test run didn't catch this. rdar://70104537
rjmccall
added a commit
that referenced
this pull request
Oct 9, 2020
Fix a ptrauth test that I broke in #34213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, emitTypeMetadataRef does a blocking request for complete metadata, which is the right thing to do for most purposes in IRGen. Unfortunately, it's actively dangerous in code that can be called during metadata completion, like an associated conformance accessor because it can cause artificial dependency cycles that the runtim isn't equipped to detect, much less solve.
This is a partial fix for rdar://69901318, which also exposes a bad metadata access path that seems to be causing an artificial problem.