[cxx-interop] Rename tests in Cxx/templates to show they are class templates. #34086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates. Once we have tests for both class templates and function templates, it will be important that they are differenciated.
zoecarver
requested review from
hlopko,
gribozavr,
MForster and
varungandhi-apple
varungandhi-apple
approved these changes
Sep 25, 2020
|
@swift-ci please smoke test. |
|
(I'll hold off on merging for a day or two in case anyone else has comments/reviews.) |
|
Wow you're fast :) Thank you Zoe! |
ainu-bot
pushed a commit
to google/swift
that referenced
this pull request
Sep 28, 2020
* 'master' of github.com:apple/swift: (37 commits) [android] Disable a test that needs LTO support. [Function builders] Add support for function builders on stored struct properties. [cxx-interop] Rename tests in Cxx/templates to show they are class templates. (swiftlang#34086) [Concurrency] (De-)mangling for SIL @async function types. Sema: Rename coerceObjectArgumentToType() to coerceSelfArgumentToType() Sema: Simplify adjustSelfTypeForMember() a little bit to avoid a cycle Sema: Fix diagnoseSelfAssignment() with computed properties [Gardening] Rename Incremental/PrivateDependencies to Incremental/Dependencies [ownership] Teach the ownership verifier how to verify that guaranteed yielded values are only used within the coroutine's lifetime. Sema: Don't trigger ImplInfoRequest from TypeChecker::buildRefExpr() Sema: Use ASTScope::lookupSingleLocalDecl() in BodyInitKindRequest Sema: Use ASTScope::lookupSingleLocalDecl() in CSGen's CollectVarRefs pass Sema: Use ASTScope::lookupSingleLocalDecl() in MissingOptionalUnwrapFailure ASTScope: Add a new lookupSingleLocalDecl() entry point AST: Convert ConstructorDecl::getDelegatingOrChainedInitKind() into a request WinSDK: extract version into a separate submodule Revert "Merge pull request swiftlang#33205 from meg-gupta/ometofunctionpass" Revert "[ownership] Move OME after CopyForwarding (swiftlang#33106)" [Type checker] Eliminate a use-after-free due to C++ temporaries. Install Incremental External Dependency Integration Code ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we have tests for both class templates and function templates it will be important that they are differentiated.
Refs.