[ownership] Add a frontend option to stop optimizing right before we lower ownership. #33984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lower ownership. Specifically the option: -sil-stop-optzns-before-lowering-ownership. This makes it possible to write end-to-end tests on OSSA passes. Before one would have to pattern match after ownership was lowered, losing the ability to do finegrained FileCheck pattern matching on ossa itself.
|
@swift-ci smoke test |
meg-gupta
approved these changes
Sep 17, 2020
gottesmm
added a commit
to gottesmm/swift
that referenced
this pull request
Sep 18, 2020
I had this originally before landing swiftlang#33984, but it got merged while rebasing into the wrong patch by mistake. Upstreaming ti now as a result.
gottesmm
added a commit
that referenced
this pull request
Sep 20, 2020
…d453ce40de03aa [gardening] Add a test case for #33984
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Sep 20, 2020
* 'master' of github.com:apple/swift: [gardening] Add a test case for swiftlang#33984
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Sep 21, 2020
I had this originally before landing swiftlang#33984, but it got merged while rebasing into the wrong patch by mistake. Upstreaming ti now as a result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically the option: -sil-stop-optzns-before-lowering-ownership. This makes
it possible to write end-to-end tests on OSSA passes. Before one would have to
pattern match after ownership was lowered, losing the ability to do finegrained
FileCheck pattern matching on ossa itself.