Skip to content

[SIL] Move from SILFunction to SILFunctionType flag for async. #33554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nate-chandler
Copy link
Contributor

Previously, the flag had been applied to a SILFunction. That was incorrect because the bit was not part of the type of a function, which meant that only function declarations but not values could be annotated.

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler merged commit 363dc4e into swiftlang:master Aug 19, 2020
@nate-chandler nate-chandler deleted the move-flag-to-SILFunctionType-from-SILFunction branch August 19, 2020 22:01
@varungandhi-apple
Copy link
Contributor

varungandhi-apple commented Aug 22, 2020

Could you please move this flag onto SILExtInfoBuilder instead of being on SILFunctionType? ASTExtInfoBuilder has a similar isAsync bit. That will make the changes "just fall out" instead of having to update call-sites for the different constructors and the Profile function later #33559.

(I'm happy to implement that change if you're busy with other stuff.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants