[Importer] define SWIFT_SDK_OVERLAY_DISPATCH_EPOCH on non-Darwin platforms #3346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forms The importer also processes libdispatch headers on non-Darwin platforms; define SWIFT_SDK_OVERLAY_DISPATCH_EPOCH on them as well.
|
Hm. Does it ever make sense for swift-corelibs-dispatch and swiftc to be out of sync? If not, I would rather leave the epoch mechanism on Darwin platforms. (We added it because GCD and Swift ship separately within an Apple release.) |
|
Not clear to me. There are a couple of places in the dispatch header files right now that is (a) reachable on linux and (b) conditionalized on the the value of dispatch_epoch. But that could be wrong and the right fix could be to remove that code. It's related to making dispatch_once unavailable for Swift3. |
|
Closing as not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
The clang importer also processes libdispatch headers on non-Darwin platforms;
define SWIFT_SDK_OVERLAY_DISPATCH_EPOCH on them as well. This enables
code in the dispatch header files to determine on all platforms that (1) an overlay is
being built and (2) what level of dispatch overlay is desired.
It enables libdispatch pull request swiftlang/swift-corelibs-libdispatch#97
Resolved bug number: (SR-)
None.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.