[5.3][CSGen] Add a null check to prevent using invalid superclass type #33084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While generating constraints for `SuperRefExpr` generator has to figure out a type of superclass associated with a current reference. Doing so might produce an empty type (aka `Type()`) when resolution fails, so `getSuperType` needs to check whether type is valid before attempting to wrap it into `MetatypeType`. Resolves: rdar://problem/50819554 (cherry picked from commit 8f73ff4)
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
DougGregor
approved these changes
Jul 24, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #33083
While generating constraints for
SuperRefExprgenerator has to figure outa type of superclass associated with a current reference. Doing so might
produce an empty type (aka
Type()) when resolution fails, sogetSuperTypeneeds to check whether type is valid before attempting to wrap it into
MetatypeType.Scope: Limited to expressions which reference invalid superclass type
Resolves: rdar://problem/50819554
Risk: Very Low
Testing: Added regression tests
Reviewer: @hborla
Resolves: rdar://problem/50819554
(cherry picked from commit 8f73ff4)