[cxx-interop] [nfc] Make ClangTypeConverter.h a public header. #33054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way it can be used all over the code base.
|
Please don't widen the scope of this header - there's already a really bad layering violation because the ASTContext needs access to some tables in ClangImporter. What dependency are you trying to get at here? |
|
That's unfortunate. We should aim to not have this dependency leak even further into the compiler. The Clang Importer is intended to map imported declarations to Swift code. If we need to carry along additional information from Clang, we need to use the attached Clang node pointers to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way it can be used all over the code base.
Refs #33053.