Generalize the MemAccessUtils API for use outside of access enforcement #32953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update, clarify, and prepare for generalization.
For use outside access enforcement passes. Add isUniquelyIdentifiedAfterEnforcement. Rename functions for clarity and generality. Rename isUniquelyIdentifiedOrClass to isFormalAccessBase. Rename findAccessedStorage to identifyFormalAccess. Rename findAccessedStorageNonNested to findAccessedStorage. Part of generalizing the utility for use outside the access enforcement passes.
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Build failed |
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also paves the way for adding an AccessPath utility.
I think the API comments are now much more helpful to people looking at this for the first time.