Fix a bunch of python lint errors #32951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci python lint |
|
|
@swift-ci python lint |
1 similar comment
|
@swift-ci python lint |
|
@swift-ci Please test |
|
@CodaFi There are about a dozen more issues still to be fixed before Python 3 lint is happy with this. Once that's done, it would be great to get the "python lint" CI updated to use Python 3 lint. |
|
Build failed |
|
Build failed |
|
@swift-ci Please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 lint seems to catch a lot more issues than Python 2 lint.
This PR contains fixes for a number of them. The issues include:
las a variable name. This is easily confused with1orI. (Python_lint also complains aboutOas a variable name for the same reason.)print()statements (these are required in python 3)