Skip to content

test: make validate_parse more python3 friendly #32688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2020

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jul 2, 2020

Use io.open to open the files with the correct encoding and to allow
proper newline specification. This allows the script to be python 2 and
python 3 compatible.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Use `io.open` to open the files with the correct encoding and to allow
proper newline specification.  This allows the script to be python 2 and
python 3 compatible.
@compnerd
Copy link
Member Author

compnerd commented Jul 2, 2020

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jul 2, 2020

CC: @tachoknight @drexin @CodaFi

@swift-ci
Copy link
Contributor

swift-ci commented Jul 2, 2020

Build failed
Swift Test OS X Platform
Git Sha - 3ed6c99

@compnerd
Copy link
Member Author

compnerd commented Jul 3, 2020

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Jul 3, 2020

@swift-ci please test Windows platform

@swift-ci
Copy link
Contributor

swift-ci commented Jul 3, 2020

Build failed
Swift Test OS X Platform
Git Sha - 3ed6c99

Attempt to appease the python linter
@compnerd
Copy link
Member Author

compnerd commented Jul 3, 2020

@swift-ci please python lint

@compnerd
Copy link
Member Author

compnerd commented Jul 3, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jul 3, 2020

Build failed
Swift Test Linux Platform
Git Sha - 3ed6c99

@swift-ci
Copy link
Contributor

swift-ci commented Jul 3, 2020

Build failed
Swift Test OS X Platform
Git Sha - 3ed6c99

@compnerd
Copy link
Member Author

compnerd commented Jul 4, 2020

@swift-ci please test windows platform

@compnerd compnerd merged commit a94df37 into swiftlang:master Jul 4, 2020
@compnerd compnerd deleted the validation branch July 4, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants