Skip to content

Remove BooleanType from docs/StdlibRationales.rst #32677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2020
Merged

Remove BooleanType from docs/StdlibRationales.rst #32677

merged 1 commit into from
Jul 3, 2020

Conversation

benrimmington
Copy link
Contributor

@benrimmington benrimmington commented Jul 2, 2020 •
edited
Loading

The BooleanType protocol was renamed to Boolean in SE-0006, and then removed in SE-0109.

@benrimmington
Copy link
Contributor Author

Cc: @varungandhi-apple

varungandhi-apple
varungandhi-apple approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@varungandhi-apple varungandhi-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! This seems reasonable, since anyone in practice is unlikely to need this. Moreover, as you pointed out, we have the swift-evolution documents which we can point them to.

@varungandhi-apple
Copy link
Contributor

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 0d44dad into swiftlang:master Jul 3, 2020
@benrimmington benrimmington deleted the se-0109-remove-boolean branch July 4, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varungandhi-apple varungandhi-apple varungandhi-apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benrimmington @varungandhi-apple @swift-ci