[verifier] [cxx-interop] Remove empty return result from constructors. #32656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
commented
Jul 1, 2020
gribozavr
approved these changes
Jul 6, 2020
| Out << "Expected ReturnStmt not to have a result. A constructor should not return a result. Returned expression: "; | ||
| S->getResult()->dump(Out); | ||
| Out << "\n"; | ||
| abort(); |
There was a problem hiding this comment.
Just to double-check, return nil in failable constructors does not trigger this new error, right? It should be covered by existing tests I think, but worth checking.
There was a problem hiding this comment.
A failable constructor will return an Optional<Class> where the element is .none. So, this error is not triggered (also, for good measure, I ran a test program and it didn't trigger this error).
Set the synthesized constructor's return result to nullptr and add an ASTVerifier check that the constructor's return statement does not contain a result.
zoecarver
force-pushed
the
verifier/ast/check-result-return
branch
from
50449eb to
0605ef4
Compare
|
@swift-ci please smoke test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the synthesized constructor's return result to nullptr and add an ASTVerifier check that the constructor's return statement does not contain a result.
Refs #32534.