Skip to content

test: make round-trip-syntax-test Python 3 friendly #32648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jul 1, 2020

Make the round-trip-syntax-test tool Python 3 friendly by tweaking the
open modes and using reduce from functools as it has been removed in
Python 3.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Jul 1, 2020

CC: @tachoknight @drexin @akyrtzi

@compnerd
Copy link
Member Author

compnerd commented Jul 1, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jul 1, 2020

Build failed
Swift Test OS X Platform
Git Sha - f60af1967ff4d1f12a40982e82e1839bf04b9ea5

compnerd and others added 2 commits July 1, 2020 10:15
Make the `round-trip-syntax-test` tool Python 3 friendly by tweaking the
open modes and using `reduce` from `functools` as it has been removed in
Python 3.
@compnerd compnerd force-pushed the are-we-there-yet branch from f60af19 to 14f72b7 Compare July 1, 2020 17:19
@compnerd
Copy link
Member Author

compnerd commented Jul 1, 2020

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jul 1, 2020

@swift-ci please test Windows platform

@swift-ci
Copy link
Contributor

swift-ci commented Jul 1, 2020

Build failed
Swift Test OS X Platform
Git Sha - 14f72b7

@swift-ci
Copy link
Contributor

swift-ci commented Jul 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - 14f72b7

@compnerd
Copy link
Member Author

compnerd commented Jul 1, 2020

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Jul 1, 2020

Build failed
Swift Test OS X Platform
Git Sha - 14f72b7

Try harder to appease the python linter
@compnerd
Copy link
Member Author

compnerd commented Jul 1, 2020

@swift-ci please python lint

@compnerd
Copy link
Member Author

compnerd commented Jul 1, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jul 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - 14f72b7

@swift-ci
Copy link
Contributor

swift-ci commented Jul 1, 2020

Build failed
Swift Test OS X Platform
Git Sha - 14f72b7

@compnerd
Copy link
Member Author

compnerd commented Jul 1, 2020

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Jul 2, 2020

Build failed
Swift Test Linux Platform
Git Sha - 96127ca

@compnerd
Copy link
Member Author

compnerd commented Jul 2, 2020

@swift-ci please test Linux platform

@compnerd compnerd merged commit d87e7c8 into swiftlang:master Jul 2, 2020
@compnerd compnerd deleted the are-we-there-yet branch July 2, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants