Reopen [Diag] Create frontend flags for localization #32630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Jun 30, 2020
|
@swift-ci please test |
|
@swift-ci please ASAN test |
|
@davezarzycki Please test with your setup. |
|
@swift-ci please test Windows platform |
|
ASAN failure is a UPASS: Let's wait for @davezarzycki to try and merge afterwards. |
|
This passes. Perhaps @DougGregor's post commit review in #32568 was the source of the bug I was observing. |
|
@davezarzycki I think the failure you had before was because of this test. To be more specific the arguments passed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reopens #32568 which was reverted at #32615.
cc @xedin, @davezarzycki