Skip to content

[Diag] Refactor DiagnosticEngine to use YAML files - Reopen #32483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 25, 2020
Merged

[Diag] Refactor DiagnosticEngine to use YAML files - Reopen #32483

merged 7 commits into from
Jun 25, 2020

Conversation

HassanElDesouky
Copy link
Contributor

The last PR #32239 got reverted because it was causing build failures on the Windows bot.

I fixed the issue with files organization and I also fixed the issue mentioned in this comment #32239 (comment)

ref #32239, #32460

cc @xedin, @compnerd, @davezarzycki

HassanElDesouky
HassanElDesouky commented Jun 20, 2020
View reviewed changes
augusto2112
augusto2112 reviewed Jun 20, 2020
View reviewed changes
@LucianoPAlmeida LucianoPAlmeida requested a review from xedin June 20, 2020 15:53
LucianoPAlmeida
LucianoPAlmeida reviewed Jun 20, 2020
View reviewed changes
LucianoPAlmeida
LucianoPAlmeida reviewed Jun 20, 2020
View reviewed changes
HassanElDesouky
HassanElDesouky commented Jun 22, 2020
View reviewed changes
@HassanElDesouky HassanElDesouky changed the title [GSoC] Refactor DiagnosticEngine to use YAML files - Reopen [Diag] Refactor DiagnosticEngine to use YAML files - Reopen Jun 22, 2020
xedin
xedin reviewed Jun 22, 2020
View reviewed changes
xedin
xedin reviewed Jun 22, 2020
View reviewed changes
xedin
xedin reviewed Jun 22, 2020
View reviewed changes
xedin
xedin reviewed Jun 22, 2020
View reviewed changes
xedin
xedin reviewed Jun 22, 2020
View reviewed changes
@HassanElDesouky HassanElDesouky force-pushed the GSoC-DiagEngineRefactor-RE branch from f23a957 to c23d6a4 Compare June 23, 2020 02:38
@HassanElDesouky HassanElDesouky force-pushed the GSoC-DiagEngineRefactor-RE branch from a0b99f9 to c685d38 Compare June 23, 2020 14:46
@HassanElDesouky HassanElDesouky requested a review from xedin June 23, 2020 14:47
xedin
xedin requested changes Jun 23, 2020
View reviewed changes
HassanElDesouky
HassanElDesouky commented Jun 24, 2020
View reviewed changes
HassanElDesouky
HassanElDesouky commented Jun 24, 2020
View reviewed changes
@HassanElDesouky HassanElDesouky requested a review from xedin June 24, 2020 10:56
xedin
xedin requested changes Jun 24, 2020
View reviewed changes
@HassanElDesouky HassanElDesouky requested a review from xedin June 24, 2020 18:51
xedin
xedin approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me now!

@xedin
Copy link
Contributor

xedin commented Jun 24, 2020

@swift-ci please test

@xedin
Copy link
Contributor

xedin commented Jun 24, 2020

@swift-ci please asan test

xedin
xedin reviewed Jun 24, 2020
View reviewed changes
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 967594b

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 967594b

@xedin
Copy link
Contributor

xedin commented Jun 24, 2020

@swift-ci please test

@xedin
Copy link
Contributor

xedin commented Jun 24, 2020

@swift-ci please asan test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 967594b

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 967594b

@xedin
Copy link
Contributor

xedin commented Jun 24, 2020

@swift-ci please smoke test Windows platform

@HassanElDesouky
Copy link
Contributor Author

@xedin sorry about that. Please run tests again.

@LucianoPAlmeida
Copy link
Contributor

@swift-ci please test

@LucianoPAlmeida
Copy link
Contributor

@swift-ci please asan test

@HassanElDesouky
Copy link
Contributor Author

@LucianoPAlmeida Thank you! :)

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 559f27b

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 559f27b

@HassanElDesouky
Copy link
Contributor Author

@LucianoPAlmeida Can you run Windows tests too?

@xedin
Copy link
Contributor

xedin commented Jun 24, 2020

@swift-ci please smoke test Windows platform

@xedin
Copy link
Contributor

xedin commented Jun 24, 2020

It should be triggered automatically though (/cc @shahmishal)...

@shahmishal
Copy link
Member

It did but had not updated the GitHub UI yet - https://ci-external.swift.org/job/swift-PR-windows/4488/

@xedin
Copy link
Contributor

xedin commented Jun 24, 2020

@swift-ci please test source compatibility release

@xedin xedin merged commit 6a44443 into swiftlang:master Jun 25, 2020
@HassanElDesouky HassanElDesouky deleted the GSoC-DiagEngineRefactor-RE branch June 25, 2020 11:27
@HassanElDesouky HassanElDesouky mentioned this pull request Jun 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@davezarzycki davezarzycki davezarzycki left review comments

@augusto2112 augusto2112 augusto2112 left review comments

@LucianoPAlmeida LucianoPAlmeida LucianoPAlmeida left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HassanElDesouky @xedin @swift-ci @LucianoPAlmeida @shahmishal @davezarzycki @augusto2112