Skip to content

[Runtime] Add entry point to compare conformance descriptors. #32471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions include/swift/AST/ASTContext.h
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,11 @@ class ASTContext final {
/// for the target platform.
AvailabilityContext getCompareTypeContextDescriptorsAvailability();

/// Get the runtime availability of the
/// swift_compareProtocolConformanceDescriptors entry point for the target
/// platform.
AvailabilityContext getCompareProtocolConformanceDescriptorsAvailability();

/// Get the runtime availability of features introduced in the Swift 5.2
/// compiler for the target platform.
AvailabilityContext getSwift52Availability();
Expand Down
15 changes: 15 additions & 0 deletions include/swift/Runtime/Metadata.h
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@ const WitnessTable *swift_getAssociatedConformanceWitness(
const ProtocolRequirement *reqBase,
const ProtocolRequirement *assocConformance);

/// Determine whether two protocol conformance descriptors describe the same
/// conformance of a type to a protocol.
///
/// Runtime availability: Swift 5.4
///
/// \param lhs The first protocol conformance descriptor to compare.
/// \param rhs The second protocol conformance descriptor to compare.
///
/// \returns true if both describe the same conformance, false otherwise.
SWIFT_RUNTIME_EXPORT
SWIFT_CC(swift)
bool swift_compareProtocolConformanceDescriptors(
const ProtocolConformanceDescriptor *lhs,
const ProtocolConformanceDescriptor *rhs);

/// Fetch a uniqued metadata for a function type.
SWIFT_RUNTIME_EXPORT
const FunctionTypeMetadata *
Expand Down
12 changes: 12 additions & 0 deletions include/swift/Runtime/RuntimeFunctions.def
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,18 @@ FUNCTION(GetAssociatedConformanceWitness,
ProtocolRequirementStructTy->getPointerTo()),
ATTRS(NoUnwind, ReadNone))

// SWIFT_RUNTIME_EXPORT
// SWIFT_CC(swift) bool swift_compareProtocolConformanceDescriptors(
// const ProtocolConformanceDescriptor *lhs,
// const ProtocolConformanceDescriptor *rhs);
FUNCTION(CompareProtocolConformanceDescriptors,
swift_compareProtocolConformanceDescriptors, SwiftCC,
CompareProtocolConformanceDescriptorsAvailability,
RETURNS(Int1Ty),
ARGS(ProtocolConformanceDescriptorPtrTy,
ProtocolConformanceDescriptorPtrTy),
ATTRS(NoUnwind, ReadNone))

// Metadata *swift_getMetatypeMetadata(Metadata *instanceTy);
FUNCTION(GetMetatypeMetadata, swift_getMetatypeMetadata, C_CC, AlwaysAvailable,
RETURNS(TypeMetadataPtrTy),
Expand Down
5 changes: 5 additions & 0 deletions lib/AST/Availability.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,11 @@ AvailabilityContext ASTContext::getCompareTypeContextDescriptorsAvailability() {
return getSwiftFutureAvailability();
}

AvailabilityContext
ASTContext::getCompareProtocolConformanceDescriptorsAvailability() {
return getSwiftFutureAvailability();
}

AvailabilityContext ASTContext::getSwift52Availability() {
auto target = LangOpts.Target;

Expand Down
10 changes: 10 additions & 0 deletions lib/IRGen/IRGenModule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,16 @@ namespace RuntimeConstants {
}
return RuntimeAvailability::AlwaysAvailable;
}

RuntimeAvailability
CompareProtocolConformanceDescriptorsAvailability(ASTContext &Context) {
auto featureAvailability =
Context.getCompareProtocolConformanceDescriptorsAvailability();
if (!isDeploymentAvailabilityContainedIn(Context, featureAvailability)) {
return RuntimeAvailability::ConditionallyAvailable;
}
return RuntimeAvailability::AlwaysAvailable;
}
} // namespace RuntimeConstants

// We don't use enough attributes to justify generalizing the
Expand Down
6 changes: 6 additions & 0 deletions stdlib/public/runtime/Metadata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4993,6 +4993,12 @@ const WitnessTable *swift::swift_getAssociatedConformanceWitness(
assocConformance);
}

bool swift::swift_compareProtocolConformanceDescriptors(
const ProtocolConformanceDescriptor *lhs,
const ProtocolConformanceDescriptor *rhs) {
return MetadataCacheKey::compareProtocolConformanceDescriptors(lhs, rhs) == 0;
}

/***************************************************************************/
/*** Recursive metadata dependencies ***************************************/
/***************************************************************************/
Expand Down
9 changes: 9 additions & 0 deletions stdlib/public/runtime/MetadataCache.h
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,14 @@ class MetadataCacheKey {

auto *aDescription = awt->getDescription();
auto *bDescription = bwt->getDescription();
return compareProtocolConformanceDescriptors(aDescription, bDescription);
}

public:
/// Compare two conformance descriptors, checking their contents if necessary.
static int compareProtocolConformanceDescriptors(
const ProtocolConformanceDescriptor *aDescription,
const ProtocolConformanceDescriptor *bDescription) {
if (aDescription == bDescription)
return 0;

Expand All @@ -405,6 +413,7 @@ class MetadataCacheKey {
bDescription->getProtocol());
}

private:
/// Compare the content from two keys.
static int compareContent(const void * const *adata,
const void * const *bdata,
Expand Down