[TypeChecker] Add a entry point to be used for code completion #32391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the code completion redesign this new entry point is going to replace use of: - `typeCheckExpression` - `getTypeOfExpressionWithoutApplying` (which could be removed) and possibly other methods currently used to retrieve information for code completion purposes. Advantages of a new approach: - Avoids mutating AST; - Allows to avoid sub-expression type-checking; - Allows code completion access to multiple solutions in ambiguous cases; - Provides all possible solutions - valid and invalid (with holes); - Allows code completion to easily access not only types but overload choices and other supplimentary information associated with each solution.
|
@swift-ci please smoke test |
|
Addressed all suggestions in #32426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the code completion redesign this new entry point is going
to replace use of:
typeCheckExpressiongetTypeOfExpressionWithoutApplying(which could be removed)and possibly other methods currently used to retrieve information
for code completion purposes.
Advantages of a new approach:
overload choices and other supplimentary information associated
with each solution.