stdlib: enable runtime checking for COW support by default in assert builds. #32385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
|
@swift-ci clean test macOS |
|
Build failed |
eeckstein
force-pushed
the
enable-cow-runtime-checks
branch
from
797ccd4 to
6e7a30e
Compare
|
@swift-ci clean test |
|
Build failed |
eeckstein
force-pushed
the
enable-cow-runtime-checks
branch
from
6e7a30e to
d4f6a0d
Compare
|
@swift-ci clean test |
1 similar comment
|
@swift-ci clean test |
|
Build failed |
Array literals only need to be finalized, if the array is really allocated. In case of zero elements, no allocation is done, but the empty-array singleton is used. "Finalization" means to emit an end_cow_mutation instruction on the array. As the empty-array singleton is a read-only and shared object, it's not legal to do a end_cow_mutation on it.
…builds. This was blocked by an LLDB problem, which is now fixed (swiftlang/llvm-project#1333)
eeckstein
force-pushed
the
enable-cow-runtime-checks
branch
from
d4f6a0d to
bc27356
Compare
|
@swift-ci clean test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was blocked by an LLDB problem, which is now fixed (swiftlang/llvm-project#1333)
Also: fix a bug with array literal finalization (see commit message for details)