[Darwin test config] Use the SDK when running swift/swiftc in tests. #32357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
DougGregor
force-pushed
the
test-with-sdk-on-darwin
branch
from
7e0a59e to
d06e110
Compare
|
@swift-ci test |
|
Build failed |
|
@swift-ci test macOS |
|
Build failed |
|
@swift-ci smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci test Windows |
The Swift driver (swift/swiftc) is supposed to always be used with an accompanying SDK, which it derives from the environment. Our test infrastructure was clearing out this SDK, making it deviate from the normal operating environment unnecessarily. Switch to providing the SDK used for building the standard library, which provides a more-consistent test environment, and tag the few places in tests where we have explicit dependencies on "no SDK."
DougGregor
force-pushed
the
test-with-sdk-on-darwin
branch
from
f8e36f8 to
1ee3342
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift driver (swift/swiftc) is supposed to always be used with an
accompanying SDK, which it derives from the environment. Our test
infrastructure was clearing out this SDK, making it deviate from the
normal operating environment unnecessarily. Switch to providing the
SDK used for building the standard library, which provides a
more-consistent test environment, and tag the few places in tests
where we have explicit dependencies on "no SDK."