[SourceKit] Disable labeled trailing closure completion support except code completion #32276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
theblixguy
reviewed
Jun 9, 2020
…letion Don't insert CodeCompletionExpr at the cursor position in "conforming method list" or "typecontext" mode. This increase the chance of successful type checking. rdar://problem/63781922
rintaro
force-pushed
the
ide-conformingmethods-disablelabeledtrailingclosure-rdar63781922
branch
from
9d12851 to
67e88f4
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
benlangmuir
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't insert
CodeCompletionExprat the cursor position in "conforming method list" mode and let "postfix completion" to handle it. This increase the chance of successful type checking.rdar://problem/63781922