[Constraint system] Lift PatternBindingDecl into SolutionApplicationTarget #32221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gets. Rather than storing the record of each pattern binding entry's solution application targets as part of an applied function builder, store them within the constraint system and solution using a newly-generalized form of SolutionApplicationTargetsKey.
…arget. Generalize the code used to generate constraints and apply solutions to PatternBindingDecls so that it is handled directly by the constaint system and solution, respectively, rather than as part of the function builder transform. No functionality change, but this is a cleaner abstraction.
|
@swift-ci please smoke test |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the code used to generate constraints and apply solutions to
PatternBindingDecls so that it is handled directly by the constraint
system and solution, respectively, rather than as part of the function
builder transform. No functionality change, but this is a cleaner
abstraction.