Skip to content

[build-script] Make is_build_script_impl_product() a pure method and get rid of default Yes answer. #32218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,10 @@


class CMark(product.Product):
pass
@classmethod
def is_build_script_impl_product(cls):
"""is_build_script_impl_product -> bool

Whether this product is produced by build-script-impl.
"""
return True
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@


class Foundation(product.Product):
@classmethod
def is_build_script_impl_product(cls):
"""is_build_script_impl_product -> bool

Whether this product is produced by build-script-impl.
"""
return True

@classmethod
def product_source_name(cls):
"""product_source_name() -> str
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,10 @@


class LibCXX(product.Product):
pass
@classmethod
def is_build_script_impl_product(cls):
"""is_build_script_impl_product -> bool

Whether this product is produced by build-script-impl.
"""
return True
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@


class LibDispatch(product.Product):
@classmethod
def is_build_script_impl_product(cls):
"""is_build_script_impl_product -> bool

Whether this product is produced by build-script-impl.
"""
return True

@classmethod
def product_source_name(cls):
"""product_source_name() -> str
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@


class LibICU(product.Product):
@classmethod
def is_build_script_impl_product(cls):
"""is_build_script_impl_product -> bool

Whether this product is produced by build-script-impl.
"""
return True

@classmethod
def product_source_name(cls):
"""product_source_name() -> str
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,10 @@


class LLBuild(product.Product):
pass
@classmethod
def is_build_script_impl_product(cls):
"""is_build_script_impl_product -> bool

Whether this product is produced by build-script-impl.
"""
return True
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,10 @@


class LLDB(product.Product):
pass
@classmethod
def is_build_script_impl_product(cls):
"""is_build_script_impl_product -> bool

Whether this product is produced by build-script-impl.
"""
return True
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@ def __init__(self, args, toolchain, source_dir, build_dir):
# Add the cmake options for compiler version information.
self.cmake_options.extend(self._version_flags)

@classmethod
def is_build_script_impl_product(cls):
"""is_build_script_impl_product -> bool

Whether this product is produced by build-script-impl.
"""
return True

@property
def _compiler_vendor_flags(self):
if self.args.compiler_vendor == "none":
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def is_build_script_impl_product(cls):

Whether this product is produced by build-script-impl.
"""
return True
raise NotImplementedError

@classmethod
def is_swiftpm_unified_build_product(cls):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ def __init__(self, args, toolchain, source_dir, build_dir):
self.cmake_options.extend(
self._enable_experimental_differentiable_programming)

@classmethod
def is_build_script_impl_product(cls):
"""is_build_script_impl_product -> bool

Whether this product is produced by build-script-impl.
"""
return True

@property
def _runtime_sanitizer_flags(self):
sanitizer_list = []
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@


class XCTest(product.Product):
@classmethod
def is_build_script_impl_product(cls):
"""is_build_script_impl_product -> bool

Whether this product is produced by build-script-impl.
"""
return True

@classmethod
def product_source_name(cls):
"""product_source_name() -> str
Expand Down