[5.3][Parse] Avoid delayed member parsing for type decl with missing brace #32197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache empty member list so that 'IterableDeclContext::loadAllMembers()' doesn't perform delayed member parsing. Fixes: rdar://problem/63921896 (cherry picked from commit bdfe1b1)
|
@swift-ci Please test |
rintaro
changed the title
|
@swift-ci Please nominate |
|
Windows failure is unrelated |
tkremenek
approved these changes
Jun 5, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #32191 into
release/5.3{ ... }), it used to subjected to delayed member parsing. It was unnecessary because we know it cannot parse anything. Moreover, it used to cause crashes in fast-code-completion when such declarations are inside the function body because fast-completion does not support delayed member parsing inside function bodies. This patch fixes it by eagerly caching an empty member list to the type/extension decl.