[nfc] [util] add util to check if an instruction dominates all uses of a value #30464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es all uses of a value
zoecarver
commented
Mar 21, 2020
| /// \param a the instruction who's expected to dominate. | ||
| /// \param b the instruction who's uses are expected to be dominated. | ||
| /// \returns true if all uses of "b" are dominated by "a". Otherwise, false. | ||
| bool swift::dominatesAllUses(SILInstruction *a, SILValue b) { |
There was a problem hiding this comment.
This should take an optional dominanceInfo argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a utility function
dominatesAllUsesto check if an instruction dominates all uses of a value. NFC. Used in #30463.