Skip to content

Use single quotes instead of backticks in diagnostics #29895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Use single quotes instead of backticks in diagnostics #29895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/swift/AST/DiagnosticsSIL.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,12 +447,12 @@ ERROR(constexpr_imported_func_not_onone, none, "imported constant evaluable "

ERROR(non_physical_addressof,none,
"addressof only works with purely physical lvalues; "
"use `withUnsafePointer` or `withUnsafeBytes` unless you're implementing "
"`withUnsafePointer` or `withUnsafeBytes`", ())
"use 'withUnsafePointer' or 'withUnsafeBytes' unless you're implementing "
"'withUnsafePointer' or 'withUnsafeBytes'", ())
ERROR(non_borrowed_indirect_addressof,none,
"addressof only works with borrowable in-memory rvalues; "
"use `withUnsafePointer` or `withUnsafeBytes` unless you're implementing "
"`withUnsafePointer` or `withUnsafeBytes`", ())
"use 'withUnsafePointer' or 'withUnsafeBytes' unless you're implementing "
"'withUnsafePointer' or 'withUnsafeBytes'", ())

REMARK(opt_remark_passed, none, "%0", (StringRef))
REMARK(opt_remark_missed, none, "%0", (StringRef))
Expand Down
4 changes: 2 additions & 2 deletions include/swift/AST/DiagnosticsSema.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4843,10 +4843,10 @@ ERROR(property_wrapper_type_not_usable_from_inline,none,
"must be '@usableFromInline' or public",
(bool, bool))
WARNING(property_wrapper_wrapperValue,none,
"property wrapper's `wrapperValue` property should be renamed to "
"property wrapper's 'wrapperValue' property should be renamed to "
"'projectedValue'; use of 'wrapperValue' is deprecated", ())
WARNING(property_wrapper_init_initialValue,none,
"property wrapper's `init(initialValue:)` should be renamed "
"property wrapper's 'init(initialValue:)' should be renamed "
"to 'init(wrappedValue:)'; use of 'init(initialValue:)' is deprecated",
())
ERROR(property_wrapper_projection_value_missing,none,
Expand Down
6 changes: 3 additions & 3 deletions test/decl/var/property_wrapper_aliases.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ struct Wrapper<T> {
struct OldWrapper<T> {
var wrappedValue: T

var wrapperValue: Wrapper<T> { // expected-warning{{property wrapper's `wrapperValue` property should be renamed to 'projectedValue'; use of 'wrapperValue' is deprecated}}{{7-19=projectedValue}}
var wrapperValue: Wrapper<T> { // expected-warning{{property wrapper's 'wrapperValue' property should be renamed to 'projectedValue'; use of 'wrapperValue' is deprecated}}{{7-19=projectedValue}}
return Wrapper(wrappedValue: wrappedValue)
}
}
Expand All @@ -25,7 +25,7 @@ struct OldWrapper<T> {
struct OldWrapperWithInit<T> {
var wrappedValue: T

init(initialValue: T) { // expected-warning{{property wrapper's `init(initialValue:)` should be renamed to 'init(wrappedValue:)'; use of 'init(initialValue:)' is deprecated}}{{8-8=wrappedValue }}
init(initialValue: T) { // expected-warning{{property wrapper's 'init(initialValue:)' should be renamed to 'init(wrappedValue:)'; use of 'init(initialValue:)' is deprecated}}{{8-8=wrappedValue }}
self.wrappedValue = initialValue
}
}
Expand All @@ -34,7 +34,7 @@ struct OldWrapperWithInit<T> {
struct OldWrapperWithInit2<T> {
var wrappedValue: T

init(initialValue value: T) { // expected-warning{{property wrapper's `init(initialValue:)` should be renamed to 'init(wrappedValue:)'; use of 'init(initialValue:)' is deprecated}}{{8-20=wrappedValue}}
init(initialValue value: T) { // expected-warning{{property wrapper's 'init(initialValue:)' should be renamed to 'init(wrappedValue:)'; use of 'init(initialValue:)' is deprecated}}{{8-20=wrappedValue}}
self.wrappedValue = value
}
}
Expand Down