Skip to content

Revert "Propagate Clang types through SIL" #29350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Propagate Clang types through SIL" #29350

wants to merge 1 commit into from

Conversation

eeckstein
Copy link
Contributor

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test and merge

@eeckstein eeckstein closed this Jan 22, 2020
@eeckstein eeckstein reopened this Jan 22, 2020
@eeckstein eeckstein mentioned this pull request Jan 22, 2020
Closed
@eeckstein
Copy link
Contributor Author

swiftlang/llvm-project#623

@swift-ci smoke test

@varungandhi-apple
Copy link
Contributor

varungandhi-apple commented Jan 22, 2020 •
edited
Loading

So the change was cherry-picked to LLVM's master-rebranch as well, which makes this revert a bit trickier. Moreover, landing this again is going to be a problem. Let me make a revert which doesn't require LLDB side changes. The interaction is very small.

@varungandhi-apple
Copy link
Contributor

Closing as we merge the revert in #29354

@shahmishal shahmishal deleted the revert-29239-vg-clang-types-in-sil branch May 13, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varungandhi-apple varungandhi-apple Awaiting requested review from varungandhi-apple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eeckstein @varungandhi-apple