Fixes [SR-78] swift compiler seg fault #291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the aligned_alloc C function from the stdlib instead of malloc so that incase the alignMask is larger than what the system supports we do not get unnecessary crashes.
Fixes a segmentation fault where the IRGen module would crash when a generic (empty) struct was part of the source code because it tried to call std::next on an end iterator.
|
@manavgabhawala I prefer not to merge this change because it has a bunch of changes to different files. Some of the commit messages are not informative, like "Update Heap.cpp", twice. Please submit a new pull request with a single commit that includes a fix for a single issue with a testcase. |
| @@ -2032,6 +2032,10 @@ SILType irgen::getSingletonAggregateFieldType(IRGenModule &IGM, | |||
| // If there's only one stored property, we have the layout of its field. | |||
| auto allFields = structDecl->getStoredProperties(); | |||
| auto field = allFields.begin(); | |||
There was a problem hiding this comment.
Wouldn't it be better to check for empty here?
if (allFields.empty()) {
return SILType();
}
|
Sorry about the multiple commits, I was trying to get my feet wet. I created a new clean pull request and included the suggestion by @AlexDenisov. Moved to #293 |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
…xtended-tests Revert "Fix compilation warnings in extended test suite"
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Add Xcode 10.1 configuration to project_precommit_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SR-78 swift compiler segmentation fault. The IRGen module would crash when a generic (empty) struct was part of the source code because it tried to call std::next on an end iterator, adds in a guard to prevent against that and also adds a test case to add in this check.
Added test case that caused the old compiler to crash (I'm not sure if this is the right way to integrate it in the testing suite).