Skip to content

[Measurement only] Revert "ClangImporter: Use a separate CompilerInstance for canReadPCH" #28145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Measurement only] Revert "ClangImporter: Use a separate CompilerInstance for canReadPCH" #28145

wants to merge 1 commit into from

Conversation

beccadax
Copy link
Contributor

@beccadax beccadax commented Nov 8, 2019

This PR reverts #28125. I don't plan to merge it; I just want to see if it had any performance impact so we aren't surprised by a regression later.

@beccadax
Copy link
Contributor Author

beccadax commented Nov 8, 2019

@swift-ci please test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Nov 8, 2019

Summary for master full

Unexpected test results, excluded stats for RxCocoa, SwifterSwift, Base64CoderSwiftUI

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 39,946,109,133,013 39,781,037,220,356 -165,071,912,657 -0.41%
LLVM.NumLLVMBytesOutput 1,775,579,064 1,775,583,568 4,504 0.0%
time.swift-driver.wall 3016.4s 3034.0s 17.6s 0.58%

debug-batch detailed

Regressed (2)
name old new delta delta_pct
Driver.NumDriverPipePolls 83,010 83,879 869 1.05% ⛔
Driver.NumDriverPipeReads 73,981 74,870 889 1.2% ⛔
Improved (5)
name old new delta delta_pct
AST.NumLookupQualifiedInModule 2,350,027 2,326,289 -23,738 -1.01% ✅
AST.NumSourceLinesPerSecond 4,702,142 4,631,773 -70,369 -1.5% ✅
Sema.CollectOverriddenDeclsRequest 6,264,203 6,173,468 -90,735 -1.45% ✅
Sema.ProvideDefaultImplForRequest 6,264,203 6,173,468 -90,735 -1.45% ✅
Sema.USRGenerationRequest 7,529,905 7,429,383 -100,522 -1.33% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (189)
name old new delta delta_pct
AST.ImportSetCacheHit 1,518,524 1,517,597 -927 -0.06%
AST.ImportSetCacheMiss 410,314 410,173 -141 -0.03%
AST.ImportSetFoldHit 118,850 118,819 -31 -0.03%
AST.ImportSetFoldMiss 291,464 291,353 -111 -0.04%
AST.ModuleShadowCacheHit 1,951 1,951 0 0.0%
AST.ModuleShadowCacheMiss 1,512 1,512 0 0.0%
AST.ModuleVisibilityCacheHit 28,562 28,563 1 0.0%
AST.ModuleVisibilityCacheMiss 6,441 6,441 0 0.0%
AST.NumASTBytesAllocated 49,314,661,008 49,156,301,332 -158,359,676 -0.32%
AST.NumASTScopeLookups 3,412,029 3,411,802 -227 -0.01%
AST.NumBraceStmtASTScopeExpansions 612,072 612,072 0 0.0%
AST.NumBraceStmtASTScopes 612,072 612,072 0 0.0%
AST.NumDecls 138,616 138,616 0 0.0%
AST.NumDependencies 285,692 285,654 -38 -0.01%
AST.NumInfixOperators 53,324 53,324 0 0.0%
AST.NumIterableTypeBodyASTScopeExpansions 222,562 222,557 -5 -0.0%
AST.NumIterableTypeBodyASTScopes 271,407 271,431 24 0.01%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 266,034 266,034 0 0.0%
AST.NumLocalTypeDecls 250 250 0 0.0%
AST.NumLookupInModule 5,322,533 5,298,578 -23,955 -0.45%
AST.NumLookupQualifiedInAnyObject 291 291 0 0.0%
AST.NumLookupQualifiedInNominal 7,108,933 7,102,727 -6,206 -0.09%
AST.NumModuleLookupClassMember 7,167 7,167 0 0.0%
AST.NumModuleLookupValue 40,208,977 40,179,464 -29,513 -0.07%
AST.NumObjCMethods 24,210 24,210 0 0.0%
AST.NumPostfixOperators 49 49 0 0.0%
AST.NumPrecedenceGroups 25,489 25,489 0 0.0%
AST.NumPrefixOperators 99 99 0 0.0%
AST.NumReferencedDynamicNames 199 199 0 0.0%
AST.NumReferencedMemberNames 6,262,420 6,262,420 0 0.0%
AST.NumReferencedTopLevelNames 473,489 473,489 0 0.0%
AST.NumSourceBuffers 309,939 309,939 0 0.0%
AST.NumSourceLines 4,663,343 4,663,343 0 0.0%
AST.NumTotalClangImportedEntities 4,818,739 4,807,183 -11,556 -0.24%
AST.NumUnqualifiedLookup 3,553,717 3,553,490 -227 -0.01%
Driver.ChildrenMaxRSS 226,605,428,736 225,347,272,704 -1,258,156,032 -0.56%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 27,665 27,665 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 853,780,815,176 850,946,980,088 -2,833,835,088 -0.33%
Frontend.NumInstructionsExecuted 39,946,109,133,013 39,781,037,220,356 -165,071,912,657 -0.41%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 195,454 195,454 0 0.0%
IRModule.NumIRBasicBlocks 6,748,358 6,748,358 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 3,321,761 3,321,761 0 0.0%
IRModule.NumIRGlobals 3,615,464 3,615,464 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 86,168,360 86,168,360 0 0.0%
IRModule.NumIRNamedMetaData 133,585 133,585 0 0.0%
IRModule.NumIRValueSymbols 6,286,729 6,286,729 0 0.0%
LLVM.NumLLVMBytesOutput 1,775,579,064 1,775,583,568 4,504 0.0%
Parse.NumFunctionsParsed 265,973 265,973 0 0.0%
Parse.NumIterableDeclContextParsed 585,974 585,966 -8 -0.0%
Parse.ParseAbstractFunctionBodyRequest 244,344 244,344 0 0.0%
Parse.ParseMembersRequest 458,964 458,956 -8 -0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,695,873 1,695,873 0 0.0%
SILModule.NumSILGenGlobalVariables 52,820 52,820 0 0.0%
SILModule.NumSILGenVtables 18,505 18,505 0 0.0%
SILModule.NumSILGenWitnessTables 71,484 71,484 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 2,429,051 2,429,051 0 0.0%
SILModule.NumSILOptGlobalVariables 54,406 54,406 0 0.0%
SILModule.NumSILOptVtables 31,180 31,180 0 0.0%
SILModule.NumSILOptWitnessTables 156,516 156,516 0 0.0%
Sema.AbstractGenericSignatureRequest 20,771 20,771 0 0.0%
Sema.AccessLevelRequest 10,587,548 10,503,675 -83,873 -0.79%
Sema.AreAllStoredPropertiesDefaultInitableRequest 20,785 20,785 0 0.0%
Sema.AttachedFunctionBuilderRequest 3 3 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 527,957 527,957 0 0.0%
Sema.AttachedPropertyWrappersRequest 2,079,650 2,079,639 -11 -0.0%
Sema.ClassAncestryFlagsRequest 93,794 93,794 0 0.0%
Sema.CompareDeclSpecializationRequest 455,343 453,626 -1,717 -0.38%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 3 3 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 52,655 52,658 3 0.01%
Sema.DefaultDefinitionTypeRequest 7,618 7,618 0 0.0%
Sema.DefaultTypeRequest 455,450 455,450 0 0.0%
Sema.EmittedMembersRequest 25,617 25,617 0 0.0%
Sema.EnumRawTypeRequest 21,037 21,037 0 0.0%
Sema.EnumRawValuesRequest 9,967 9,967 0 0.0%
Sema.ExistentialConformsToSelfRequest 19,293 19,239 -54 -0.28%
Sema.ExistentialTypeSupportedRequest 15,672 15,672 0 0.0%
Sema.ExpandASTScopeRequest 6,283,662 6,283,632 -30 -0.0%
Sema.ExtendedNominalRequest 470,079 470,079 0 0.0%
Sema.ExtendedTypeRequest 73,932 73,932 0 0.0%
Sema.FunctionBuilderTypeRequest 3 3 0 0.0%
Sema.FunctionOperatorRequest 50,335 50,335 0 0.0%
Sema.GenericParamListRequest 8,582,933 8,524,714 -58,219 -0.68%
Sema.GenericSignatureRequest 2,622,678 2,618,246 -4,432 -0.17%
Sema.GetDestructorRequest 26,072 26,072 0 0.0%
Sema.HasDefaultInitRequest 50,736 50,736 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 0 0 0 0.0%
Sema.HasMemberwiseInitRequest 18,948 18,948 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 50,746 50,746 0 0.0%
Sema.InferredGenericSignatureRequest 160,440 160,435 -5 -0.0%
Sema.InheritedDeclsReferencedRequest 4,944,764 4,910,335 -34,429 -0.7%
Sema.InheritedTypeRequest 269,904 269,605 -299 -0.11%
Sema.InheritsSuperclassInitializersRequest 25,931 25,931 0 0.0%
Sema.InitKindRequest 89,592 89,592 0 0.0%
Sema.InterfaceTypeRequest 12,484,479 12,411,324 -73,155 -0.59%
Sema.IsABICompatibleOverrideRequest 134,407 134,407 0 0.0%
Sema.IsAccessorTransparentRequest 305,706 305,706 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDynamicRequest 1,672,377 1,672,377 0 0.0%
Sema.IsFinalRequest 2,400,765 2,389,922 -10,843 -0.45%
Sema.IsGetterMutatingRequest 412,365 412,365 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,336,084 2,334,744 -1,340 -0.06%
Sema.IsObjCRequest 1,482,767 1,482,481 -286 -0.02%
Sema.IsSetterMutatingRequest 334,342 334,342 0 0.0%
Sema.IsStaticRequest 2,995,838 2,994,252 -1,586 -0.05%
Sema.LazyStoragePropertyRequest 2,114 2,114 0 0.0%
Sema.LookupPrecedenceGroupRequest 173,687 173,687 0 0.0%
Sema.MangleLocalTypeDeclRequest 500 500 0 0.0%
Sema.NamedLazyMemberLoadFailureCount 17,566 17,540 -26 -0.15%
Sema.NamedLazyMemberLoadSuccessCount 27,406,707 27,393,180 -13,527 -0.05%
Sema.NamingPatternRequest 173,904 173,893 -11 -0.01%
Sema.NeedsNewVTableEntryRequest 653,285 653,285 0 0.0%
Sema.NominalTypeLookupDirectCount 34,025,034 33,978,455 -46,579 -0.14%
Sema.NumAccessorBodiesSynthesized 187,574 187,574 0 0.0%
Sema.NumAccessorsSynthesized 274,158 274,158 0 0.0%
Sema.NumConformancesDeserialized 7,910,036 7,864,634 -45,402 -0.57%
Sema.NumConstraintScopes 26,924,567 26,918,915 -5,652 -0.02%
Sema.NumConstraintsConsideredForEdgeContraction 86,075,966 86,073,928 -2,038 -0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 60,646,972 60,301,030 -345,942 -0.57%
Sema.NumDeclsTypechecked 1,386,848 1,386,848 0 0.0%
Sema.NumFunctionsTypechecked 524,281 524,281 0 0.0%
Sema.NumGenericSignatureBuilders 1,155,519 1,152,925 -2,594 -0.22%
Sema.NumLazyIterableDeclContexts 7,291,739 7,273,314 -18,425 -0.25%
Sema.NumLazyRequirementSignatures 724,213 723,803 -410 -0.06%
Sema.NumLazyRequirementSignaturesLoaded 490,218 489,820 -398 -0.08%
Sema.NumLeafScopes 17,274,034 17,269,514 -4,520 -0.03%
Sema.NumTypesDeserialized 17,958,777 17,900,680 -58,097 -0.32%
Sema.NumTypesValidated 1,350,304 1,350,293 -11 -0.0%
Sema.NumUnloadedLazyIterableDeclContexts 4,428,381 4,426,164 -2,217 -0.05%
Sema.OpaqueReadOwnershipRequest 259,956 259,956 0 0.0%
Sema.OpaqueResultTypeRequest 0 0 0 0.0%
Sema.OperatorPrecedenceGroupRequest 747 747 0 0.0%
Sema.OverriddenDeclsRequest 2,218,227 2,209,923 -8,304 -0.37%
Sema.ParamSpecifierRequest 1,167,828 1,167,828 0 0.0%
Sema.PatternBindingEntryRequest 424,088 424,077 -11 -0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 523,018 523,018 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 527,957 527,957 0 0.0%
Sema.PropertyWrapperMutabilityRequest 606,228 606,228 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 1 1 0 0.0%
Sema.ProtocolRequiresClassRequest 58,274 57,984 -290 -0.5%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 106,028 106,028 0 0.0%
Sema.RequirementSignatureRequest 549,199 548,468 -731 -0.13%
Sema.RequiresOpaqueAccessorsRequest 1,272,662 1,272,662 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 250,144 250,144 0 0.0%
Sema.ResilienceExpansionRequest 1,671,775 1,671,770 -5 -0.0%
Sema.ResolveImplicitMemberRequest 2,932,418 2,931,146 -1,272 -0.04%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResultTypeRequest 623,744 623,744 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SelfAccessKindRequest 765,738 765,088 -650 -0.08%
Sema.SelfBoundsFromWhereClauseRequest 6,563,538 6,512,237 -51,301 -0.78%
Sema.SetterAccessLevelRequest 140,402 140,402 0 0.0%
Sema.StorageImplInfoRequest 1,360,548 1,360,548 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 29,625 29,625 0 0.0%
Sema.StoredPropertiesRequest 283,626 283,626 0 0.0%
Sema.StructuralTypeRequest 2,028 2,028 0 0.0%
Sema.SuperclassDeclRequest 384,479 383,926 -553 -0.14%
Sema.SuperclassTypeRequest 48,361 48,361 0 0.0%
Sema.SynthesizeAccessorRequest 274,158 274,158 0 0.0%
Sema.SynthesizeDefaultInitRequest 4,743 4,743 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,024 3,024 0 0.0%
Sema.TypeCheckFunctionBodyUntilRequest 524,281 524,281 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 28,306 28,309 3 0.01%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 7,823 7,823 0 0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 219,723 219,073 -650 -0.3%
Sema.UnderlyingTypeRequest 32,678 32,678 0 0.0%
Sema.ValueWitnessRequest 62,123 62,123 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 48,773,305,017,206 48,752,993,024,591 -20,311,992,615 -0.04%
LLVM.NumLLVMBytesOutput 1,921,688,608 1,921,693,212 4,604 0.0%
time.swift-driver.wall 5424.1s 5430.4s 6.3s 0.12%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (18)
name old new delta delta_pct
AST.NumLoadedModules 29,851 29,851 0 0.0%
AST.NumTotalClangImportedEntities 1,205,865 1,205,865 0 0.0%
IRModule.NumIRBasicBlocks 5,458,131 5,458,131 0 0.0%
IRModule.NumIRFunctions 2,830,593 2,830,593 0 0.0%
IRModule.NumIRGlobals 3,149,963 3,149,963 0 0.0%
IRModule.NumIRInsts 52,950,144 52,950,144 0 0.0%
IRModule.NumIRValueSymbols 5,627,429 5,627,429 0 0.0%
LLVM.NumLLVMBytesOutput 1,921,688,608 1,921,693,212 4,604 0.0%
SILModule.NumSILGenFunctions 1,181,751 1,181,751 0 0.0%
SILModule.NumSILOptFunctions 1,685,627 1,685,627 0 0.0%
Sema.NumConformancesDeserialized 3,732,440 3,732,440 0 0.0%
Sema.NumConstraintScopes 26,623,708 26,623,708 0 0.0%
Sema.NumDeclsDeserialized 10,269,084 10,269,084 0 0.0%
Sema.NumFunctionsTypechecked 527,903 527,903 0 0.0%
Sema.NumGenericSignatureBuilders 277,085 277,085 0 0.0%
Sema.NumLazyIterableDeclContexts 1,307,489 1,307,489 0 0.0%
Sema.NumTypesDeserialized 5,163,139 5,163,139 0 0.0%
Sema.NumTypesValidated 817,845 817,845 0 0.0%

@beccadax beccadax closed this Nov 9, 2019
@shahmishal shahmishal deleted the revert-28125-clang-importer/separate-compiler-instance-for-can-read-pch branch May 13, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beccadax @swift-ci