[AST] emitLetToVarNoteIfSimple should also check if the method/accessor is explicitly non-mutating #27641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccessor is explicitly 'nonmutating' Otherwise, we will simply insert the 'mutating' fix-it after 'nonmutating', leading to another error that says both cannot be used at the same time
theblixguy
changed the title
|
@swift-ci please smoke test |
jrose-apple
approved these changes
Oct 14, 2019
…utating" via fix-it
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emitLetToVarNoteIfSimple()emits a diagnostic with a fix-it to addmutatingto a method or accessor. However, it's possible that the method or accessor is explicitlynonmutating. In that case, we end up adding themutatingafternonmutating, leading to another error:Method must not be declared both nonmutating and mutating(if we have a method) orExpected 'get', 'set', 'willSet', or 'didSet' keyword to start an accessor definition(if we have an accessor, like aset).We should check whether we have an explicit
nonmutatingattribute and instead of inserting the fix-it, we should replacenonmutatingwithmutating.(I noticed when I was writing some tests!)