[Runtime] Handle existential target types in swift_dynamicCastMetatypeImpl #27572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eImpl. This fixes cases like `type is T.Type` when T is generic specialized to a protocol type. Note: the compiler can still optimize these checks away and will optimize this check down to `false` in some cases. We'll want to fix that as well. rdar://problem/56044443
DougGregor
requested changes
Oct 10, 2019
…col conformance. This is cleaner and it fixes a bunch of cases the old code didn't handle: @objc protocols, class bounds, and superclass constraints. rdar://problem/56044443
|
@swift-ci plese test |
|
Thank you for pointing this stuff out. It would have been embarrassing to find out later. |
|
@swift-ci please test |
|
Build failed |
rdar://problem/56044443
|
@swift-ci please test |
|
Build failed |
|
Build failed |
rdar://problem/56044443
|
@swift-ci please test |
|
Build failed |
|
Build failed |
…e test even when --test-optimized is passed. rdar://problem/56044443
|
@swift-ci please test |
|
Build failed |
|
Build failed |
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
May 8, 2020
This turned out to be fallout from swiftlang#27572 which was in turn motivated by our confusing metatype syntax when generic variables are bound to protocols. In particular, the earlier PR was an attempt to make the expression `x is T.Type` (where `T` is a generic type variable bound to a protocol `P`) behave the same as `x is P.Type` (where `P` is a protocol). Unfortunately, the generic `T.Type` actually binds to `P.Protocol` in this case (not `P.Type`), so the original motivation was flawed, and as it happens, `x is T.Type` already behaved the same as `x is P.Protocol` in this situation. This PR reverts that earlier change and beefs up some of the tests around these behaviors. Resolves SR-12486 Resolves rdar://62201613 Reverts PR#27572
tbkka
added a commit
that referenced
this pull request
Jul 2, 2020
* SR-12486: `T.self is Any.Protocol` is broken This turned out to be fallout from #27572 which was in turn motivated by our confusing metatype syntax when generic variables are bound to protocols. In particular, the earlier PR was an attempt to make the expression `x is T.Type` (where `T` is a generic type variable bound to a protocol `P`) behave the same as `x is P.Type` (where `P` is a protocol). Unfortunately, the generic `T.Type` actually binds to `P.Protocol` in this case (not `P.Type`), so the original motivation was flawed, and as it happens, `x is T.Type` already behaved the same as `x is P.Protocol` in this situation. This PR reverts that earlier change and beefs up some of the tests around these behaviors. Resolves SR-12486 Resolves rdar://62201613 Reverts PR#27572
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
Jul 6, 2020
* SR-12486: `T.self is Any.Protocol` is broken This turned out to be fallout from swiftlang#27572 which was in turn motivated by our confusing metatype syntax when generic variables are bound to protocols. In particular, the earlier PR was an attempt to make the expression `x is T.Type` (where `T` is a generic type variable bound to a protocol `P`) behave the same as `x is P.Type` (where `P` is a protocol). Unfortunately, the generic `T.Type` actually binds to `P.Protocol` in this case (not `P.Type`), so the original motivation was flawed, and as it happens, `x is T.Type` already behaved the same as `x is P.Protocol` in this situation. This PR reverts that earlier change and beefs up some of the tests around these behaviors. Resolves SR-12486 Resolves rdar://62201613 Reverts PR#27572
tbkka
added a commit
that referenced
this pull request
Jul 7, 2020
* SR-12486: `T.self is Any.Protocol` is broken This turned out to be fallout from #27572 which was in turn motivated by our confusing metatype syntax when generic variables are bound to protocols. In particular, the earlier PR was an attempt to make the expression `x is T.Type` (where `T` is a generic type variable bound to a protocol `P`) behave the same as `x is P.Type` (where `P` is a protocol). Unfortunately, the generic `T.Type` actually binds to `P.Protocol` in this case (not `P.Type`), so the original motivation was flawed, and as it happens, `x is T.Type` already behaved the same as `x is P.Protocol` in this situation. This PR reverts that earlier change and beefs up some of the tests around these behaviors. Resolves SR-12486 Resolves rdar://62201613 Reverts PR#27572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes cases like
type is T.Typewhen T is generic specialized to a protocol type.Note: the compiler can still optimize these checks away and will optimize this check down to
falsein some cases. We'll want to fix that as well.rdar://problem/56044443