Skip to content

Revert "Optimize toolchain size by preserving TensorFlow library symlinks." #27142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2019
Merged

Revert "Optimize toolchain size by preserving TensorFlow library symlinks." #27142

merged 1 commit into from
Sep 13, 2019

Conversation

dan-zheng
Copy link
Contributor

Reverts #27032.

swift test fails for tensorflow/swift-apis and this PR is a prime suspect:

/usr/bin/ld.gold: error: cannot open /swift-tensorflow-toolchain/usr/lib/swift/linux/libtensorflow.so: No such file or directory

@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Sep 12, 2019
@dan-zheng dan-zheng requested a review from marcrasi September 13, 2019 19:09
@dan-zheng
Copy link
Contributor Author

@swift-ci Please clean test tensorflow

@dan-zheng
Copy link
Contributor Author

@swift-ci Please clean test tensorflow macOS

@dan-zheng dan-zheng merged commit dd4fd33 into tensorflow Sep 13, 2019
@dan-zheng dan-zheng deleted the revert-27032-optimize-toolchain-size branch September 13, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcrasi marcrasi Awaiting requested review from marcrasi

Assignees
No one assigned
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dan-zheng