Skip to content

Revert "[CS] Don't crash when default argument is magic literal and types don't match" #26973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2019

Conversation

theblixguy
Copy link
Collaborator

@theblixguy theblixguy commented Aug 30, 2019

Reverts #26074, as it causes a regression with generic type resolution.

See SR-11223

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@theblixguy
Copy link
Collaborator Author

Ah, I can't actually push to this branch. I wanted to move the test into compiler_crashers_2 in the meantime, so when it gets fixed, we can move it into compiler_crashers_2_fixed. I'll create another PR after this is merged.

@xedin
Copy link
Contributor

xedin commented Aug 31, 2019

Sure!

@theblixguy
Copy link
Collaborator Author

@swift-ci please smoke test and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants