Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABI/API checker: diagnose ObjC name changes as breakages #26910

Merged
merged 1 commit into from
Aug 28, 2019
Merged

ABI/API checker: diagnose ObjC name changes as breakages #26910

merged 1 commit into from
Aug 28, 2019

Conversation

nkcsgexi
Copy link
Contributor

rdar://54797695

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi nkcsgexi merged commit 03bd71c into swiftlang:master Aug 28, 2019
@jrose-apple
Copy link
Contributor

Thanks! It's missing test cases for adding and removing names while keeping the attribute, though.

@nkcsgexi
Copy link
Contributor Author

In that case, the ABI checker will show empty ObjC name has been changed to a non-empty one or vice versa.

@jrose-apple
Copy link
Contributor

I guess so, up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple Awaiting requested review from jrose-apple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkcsgexi @jrose-apple