Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModuleInterface] Add a test for multiple 'indirect' cases on one line #26893

Conversation

jrose-apple
Copy link
Contributor

Follow-up for #26311.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Contributor

@harlanhaskins harlanhaskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but why do we only split enum cases in multi-file mode?

@jrose-apple
Copy link
Contributor Author

jrose-apple commented Aug 28, 2019

Unlike PatternBindingDecl, Serialization doesn't currently preserve EnumCaseDecl, only EnumElementDecl, so emitting an interface from a bunch of partial modules has to split the elements up. We can probably pick one side or the other and standardize on it, but I wanted to get the test in regardless.

@jrose-apple jrose-apple merged commit 741af6f into swiftlang:master Aug 28, 2019
@jrose-apple jrose-apple deleted the a-test-i-promised-rintaro-a-month-ago-oops branch August 28, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants