[code-completion] Disable diagnostics during code completion and fix regressions #26888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test OS X Platform |
|
Build failed |
|
@swift-ci please test OS X Platform |
It seems disabling diagnstics doesn't introduce any regression. rdar://problem/50679428
TypeCheckExprFlags::SuppressDiagnostics is now done by DiagnosticSuppression.
…ies" This reverts commit c6eade1.
…ics in code completion There were some changes to completion results because AST mutations that were made while diagnosing are no longer happening. This patch 1) changes expression type checking to allow unresolved types when solving constraint systems, so we get a solution and apply its types in more cases, and 2) fixes a parsing issue where we would drop a ternary expression completely if the code completion point was in its true branch.
nathawes
force-pushed
the
pr-disable-diagnostics-for-code-completion-2
branch
from
91553b5
to
feb48a6
Compare
|
@swift-ci please test and merge |
|
@swift-ci test and merge |
rintaro
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just @rintaro's PR to disable diagnostics and merge diagnostic suppression mechanisms (#24842) but with additional fixes for cases the stress tester found where it regressed the completion results (the two test cases in
test/IDE/complete_in_closures.swift).It changed the completion results because AST mutations were being made while diagnosing, and these are no longer happening. On top of Rintaro's changes, this PR 1) changes expression type checking for code completion to allow unresolved types when solving so we get a solution and apply the types it did manage to resolve in more cases, and 2) fixes a parsing issue where we would sometimes drop a ternary expression completely if the code completion point was in its true branch.
Resolves rdar://problem/50679428