Skip to content

Backout SE-0246 #26809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 23, 2019
Merged

Backout SE-0246 #26809

merged 3 commits into from
Aug 23, 2019

Conversation

stephentyrone
Copy link
Contributor

@stephentyrone stephentyrone commented Aug 23, 2019 •
edited
Loading

We're working on figuring out a better source- and binary-stability solution for this change (hopefully with a good back-deployment solution as well). Since we didn't end up taking it into Swift-5.1, I'm going to back it out of master in the short-term while we replan.

Resolves rdar://problem/53956572

@stephentyrone
Copy link
Contributor Author

@swift-ci please test

@stephentyrone stephentyrone merged commit d80b1d3 into swiftlang:master Aug 23, 2019
@stephentyrone stephentyrone deleted the backout-se-0246 branch August 23, 2019 20:41
lorentey
lorentey reviewed Aug 23, 2019
View reviewed changes
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

test/api-digester/Outputs/stability-stdlib-abi.without.asserts.swift.expected
@@ -0,0 +1,133 @@
Func Double.acos(_:) has been removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks as if we have the digester baseline set to a recent master here. That seems wrong to me -- @nkcsgexi, shouldn't we use the 5.0 (or 5.1) state?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I agree (was in the process of writing up a radar about that =))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rdar://problem/54653088

@compnerd
Copy link
Member

This may have caused a regression on the android x64 build: https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=7070&view=logs&j=4805d3d2-0b91-5df3-5741-d0ea1cc955c0

@stephentyrone
Copy link
Contributor Author

stephentyrone commented Aug 24, 2019 •
edited
Loading

@compnerd yeah, it looks like the removal of Float80 on Android builds happened during the period when 246 was on master, so it needs to be applied to BuiltinMath as well.

I won't have time to put up a fix for a little bit, but I'm happy to rubber stamp one. It should be totally straightforward.

@stephentyrone
Copy link
Contributor Author

@compnerd #26824

@rxwei
Copy link
Contributor

rxwei commented Sep 10, 2019

FYI: We are keeping ElementaryFunctions in the tensorflow branch since TensorFlow optimizers depend on this.

@benrimmington benrimmington mentioned this pull request Jan 11, 2020
Merged
@dan-zheng dan-zheng mentioned this pull request Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentey lorentey lorentey left review comments

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentyrone @compnerd @rxwei @lorentey