[build-script] Installation support for sourcekit-lsp

utils/build-presets.ini

@@ -740,6 +740,7 @@ install-xctest
 install-libicu
 install-prefix=/usr
 install-libcxx
+install-sourcekit-lsp
 build-swift-static-stdlib
 build-swift-static-sdk-overlay
 build-swift-stdlib-unittest-extra
@@ -1067,7 +1068,6 @@ enable-asan
 indexstore-db=0
 sourcekit-lsp=0
 
-
 # This does not currently pass due to leakers in the optimizer.
 [preset: buildbot_incremental_linux,lsan,tools=RDA,stdlib=RDA,test=no]
 build-subdir=buildbot_incremental_lsan
@@ -1150,6 +1150,7 @@ install-skstresstester
 install-swiftevolve
 install-playgroundsupport
 install-libcxx
+install-sourcekit-lsp
 
 install-destdir=%(install_destdir)s
 

utils/build-script

@@ -793,6 +793,7 @@ class BuildScriptInvocation(object):
                         host_target, product_name))
                 product.build(host_target)
                 product.test(host_target)
+                product.install(host_target)
 
         # Extract symbols...
         for host_target in all_hosts:

utils/build_swift/driver_arguments.py

@@ -562,6 +562,8 @@ def create_argument_parser():
            help='build IndexStoreDB')
     option(['--sourcekit-lsp'], toggle_true('build_sourcekitlsp'),
            help='build SourceKitLSP')
+    option(['--install-sourcekit-lsp'], toggle_true('install_sourcekitlsp'),
+           help='install SourceKitLSP')
     option(['--toolchain-benchmarks'],
            toggle_true('build_toolchainbenchmarks'),
            help='build Swift Benchmarks using swiftpm against the just built '

utils/build_swift/tests/expected_options.py

@@ -88,6 +88,7 @@
     'build_swiftevolve': False,
     'build_indexstoredb': False,
     'build_sourcekitlsp': False,
+    'install_sourcekitlsp': False,
     'build_toolchainbenchmarks': False,
     'build_tvos': True,
     'build_tvos_device': False,
@@ -459,6 +460,7 @@ class IgnoreOption(_BaseOption):
     EnableOption('--libicu', dest='build_libicu'),
     EnableOption('--indexstore-db', dest='build_indexstoredb'),
     EnableOption('--sourcekit-lsp', dest='build_sourcekitlsp'),
+    EnableOption('--install-sourcekit-lsp', dest='install_sourcekitlsp'),
     EnableOption('--toolchain-benchmarks', dest='build_toolchainbenchmarks'),
     EnableOption('--tsan-libdispatch-test'),
     EnableOption('--long-test'),

utils/swift_build_support/swift_build_support/products/benchmarks.py

@@ -45,6 +45,9 @@ def test(self, host_target):
         bench_Osize = os.path.join(self.build_dir, 'bin', 'Benchmark_Osize')
         shell.call([bench_Osize] + cmdline)
 
+    def install(self, host_target):
+        pass
+
 
 def run_build_script_helper(host_target, product, args):
     toolchain_path = args.install_destdir

utils/swift_build_support/swift_build_support/products/indexstoredb.py

@@ -34,6 +34,9 @@ def test(self, host_target):
         if self.args.test and self.args.test_indexstoredb:
             run_build_script_helper('test', host_target, self, self.args)
 
+    def install(self, host_target):
+        pass
+
 
 def run_build_script_helper(action, host_target, product, args):
     script_path = os.path.join(

utils/swift_build_support/swift_build_support/products/product.py

@@ -56,6 +56,13 @@ def test(self, host_target):
         """
         raise NotImplementedError
 
+    def install(self, host_target):
+        """install() -> void
+
+        Install to the toolchain, for a non-build-script-impl product.
+        """
+        raise NotImplementedError
+
     def __init__(self, args, toolchain, source_dir, build_dir):
         self.args = args
         self.toolchain = toolchain

utils/swift_build_support/swift_build_support/products/sourcekitlsp.py

@@ -31,3 +31,8 @@ def test(self, host_target):
         if self.args.test and self.args.test_sourcekitlsp:
             indexstoredb.run_build_script_helper(
                 'test', host_target, self, self.args)
+
+    def install(self, host_target):
+        if self.args.install_sourcekitlsp:
+            indexstoredb.run_build_script_helper(
+                'install', host_target, self, self.args)

utils/swift_build_support/swift_build_support/products/tsan_libdispatch.py

@@ -66,3 +66,6 @@ def test(self, host_target):
 
         with shell.pushd(self.build_dir):
             shell.call(cmd, env=env)
+
+    def install(self, host_target):
+        pass