[presets] Add clang install to bots that test indexstore-db/sourcekit-lsp #26300
Conversation
…-lsp At a minimum, we need to install libIndexStore to enable testing the indexer, but it's better to also include clang/clangd, since this lets us enable all of our tests on these bots. This commit uses the swift-install-components and llvm-install-components from the Package bots, which increases the similarity between our PR tests and package bots. In addition to the sourcekit-lsp/indexstore-db PR test bots, this affects the following bots that test indexstore-db and didn't already install clang: * Linux * incremental * incremental long test * swiftpm PR test * macOS * PR test * PR smoke test * incremental * swiftpm PR test Based on looking at recent build logs for the package bots, this should only add <5 seconds to the incremental build.
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
|
@swift-ci please test |
|
Heads up @hyp and @shahmishal. |
|
Build failed |
|
macOS Toolchain Install command |
|
Build failed |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@benlangmuir do you think we can get away without installing |
|
@hyp if we install clang in the toolchain it will get used when building sourcekit-lsp/indexstore-db, which needs the c++ headers. Just for testing we could maybe find a workaround, but it's simpler and probably more robust for our bots to behave more like the package bots. |
|
@swift-ci please test |
|
@swift-ci please smoke test |
At a minimum, we need to install
libIndexStoreto enable testing the indexer, but it's better to also includeclang,clangd, andlibcxx, since (a) this makes these bots closer to the config of the "package" bots, and (b) this lets us enable all of our indexer tests that require clang[d]. This commit copies theswift-install-componentsandllvm-install-componentsfrom the package bots.In addition to the sourcekit-lsp/indexstore-db PR test bots, this affects the following bots that test indexstore-db and didn't already install clang:
Based on looking at recent build logs for the package bots, this should only add <5 seconds to the incremental build.