Skip to content

SR-7039: Build and install libdispatch static libraries #25085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2019
Merged

SR-7039: Build and install libdispatch static libraries #25085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions utils/build-script-impl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2113,7 +2113,11 @@ for host in "${ALL_HOSTS[@]}"; do

for product in "${PRODUCTS[@]}"; do
# Check if we should perform this action.
if ! [[ $(should_execute_action "${host}-${product}-build") ]]; then
tmp_product=${product}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simplify this further?

for product in ${PRODUCTS[@]} ; do
  product=${product//_static/}

should effectively give you all the changes that you need for all the products being built statically. Generalising that means that we don't need to handle each product individually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment the Foundation static libs dont build so I dont want foundation_static enabled, however once it's working I will up update to that to enable it for both. So for now just libdispatch will be enabled.

if [[ ${tmp_product} == "libdispatch_static" ]]; then
tmp_product=libdispatch
fi
if ! [[ $(should_execute_action "${host}-${tmp_product}-build") ]]; then
continue
fi

Expand Down Expand Up @@ -3463,7 +3467,11 @@ for host in "${ALL_HOSTS[@]}"; do

for product in "${PRODUCTS[@]}"; do
# Check if we should perform this action.
if ! [[ $(should_execute_action "${host}-${product}-install") ]]; then
tmp_product=${product}
if [[ ${tmp_product} == "libdispatch_static" ]]; then
tmp_product=libdispatch
fi
if ! [[ $(should_execute_action "${host}-${tmp_product}-install") ]]; then
continue
fi

Expand Down