-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Fix include guards #25070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix include guards #25070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks! = ).
@swift-ci test and merge |
@swift-ci please test and merge |
Sorry. Anyway, it seems to work fine if undoing the changes of HeapObject.h, KeyPath.h and System.h's include guards and then I found that these just have include guards of the same names as others. |
Now, It would work. |
@swift-ci please test |
@gottesmm |
stdlib/public/SwiftShims/Target.h
Outdated
@@ -31,4 +31,4 @@ | |||
# endif | |||
#endif | |||
|
|||
#endif /* SWIFT_ABI_TARGET_H */ | |||
#endif /* SWIFT_STDLIB_SHIMS_ABI_TARGET_H */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change /* to //?
ok |
@moatom could you please squash the commits into a single commit? |
@compnerd I have another question. |
Yes, use Sure, changing the ending on those in a follow up is fine. |
Done! |
@swift-ci please test |
I fixed include guards using the identifiers reserved by C++.